Index: [thread] [date] [subject] [author]
  From: Marcus Sundberg <e94_msu@e.kth.se>
  To  : ggi-develop@eskimo.com
  Date: Fri, 03 Jul 1998 10:49:41 +0200

Re: Fixes to X target event handling committed

Steve Cheng wrote:
> 
> The problems wrt caps lock key, shifts, have been fixed.
> Boy, that code is messy.
> 
> The target will also now set some modifier states (effect, normal) in the
> ggi_event.
> 
> I still have one more question though: where do caps lock, numlock, scroll
> lock belong in the modifier keys?  I don't see it in the ggi/keyboard.h.

There are lots of other keys missing from ggi/keyboard.h too.

> I'll wait for more answers before I do the same changes to the Xlib
> target.

$ diff -bud Xlib/events.c X/events.c
--- Xlib/events.c       Sat Jun 20 09:35:01 1998
+++ X/events.c  Fri Jul  3 10:37:55 1998
@@ -34,6 +34,7 @@
 #include <sys/select.h>
 #endif
 
+#include <ggi/keyboard.h>
 #include "ggi-dl.h"
 #include "Xvisual.h"
 #include "../common/evqueue.inc"
@@ -740,6 +741,8 @@
                        XlibReleaseLock;
                
                        __NewEvent(&ggievent);
+
+                       ggievent.any.type=0;
 
                        switch(event.type) { 
                                case KeyPress:> 

Looks like we should make a display/common/X-events.inc
file. ;)
(It has to be a .inc and not .c because struct Xhooks
differ between X and Xlib)

//Marcus

Index: [thread] [date] [subject] [author]