Index: [thread] [date] [subject] [author]
  From: Alexander Larsson <alla@lysator.liu.se>
  To  : ggi-develop@eskimo.com
  Date: Sun, 16 Aug 1998 21:09:21 +0200

floating point code!?

Browsing through the kgicon code i find the following:

static int convert_from_ggitimings(struct kgi_mode *mode, 
				   struct fb_var_screeninfo *var)
{
	var->pixclock = (1E6 / (mode->dclk / 1000)) * 1000;

1E6? That's a floating point constant => the division and the multiplication 
is made in floating point.
This is no good and should be fixed (which is easy).

/ Alex



Index: [thread] [date] [subject] [author]