From: Steve Cheng <elmert@ipoline.com>
  To  : GGI Mailing List <ggi-develop@eskimo.com>
  Date: Mon, 10 Aug 1998 19:18:24 -0400 (EDT)

More targets converted...

Just to let you know...

tile and xf86dga now works.
svgalib and aa now work.
starting to commit now.

Observation:

display/memory/mode.c

        LIBGGI_APPBUFS(vis)[0]->buffer.plb.stride
                = (GT_SIZE(mode->graphtype)+7)/8*mode->virt.x;
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

this is wrong.  Try 1-bit mode, (1+7)/8*virt.x...
Should be:

	((GT_SIZE(mode->graphtype) * mode->virt.x)+7) / 8

Though for get/put buffers this is ok as they are unpacked, but some app
might want packed buffers, they will need to check this.

And, Marcus, someday you'll win the obfuscated C contest:

        if (GT_SCHEME(tm->graphtype) == GT_PALETTE) {
                for (i=0; i < GT_DEPTH(tm->graphtype); i++)
                        LIBGGI_PIXFMT(vis)->clut_mask
                                = (LIBGGI_PIXFMT(vis)->clut_mask << 1) | 1;
        }

why not just:

	if (GT_SCHEME(tm->graphtype) == GT_PALETTE)
		LIBGGI_PIXFMT(vis)->clut_mask = (1 << GT_DEPTH(tm->graphtype) - 1;

???

Sorry for so much messages, lots to hack today :)

--
Steve Cheng               

email: steve@ggi-project.org   
www: <http://shell.ipoline.com/~elmert/>;